Skip to content

Fix dataclass comment typo (_eq__ -> __eq__)#26433

Merged
ericvsmith merged 1 commit into
python:mainfrom
SeanGrady:fix-dataclass-comment-typo
May 28, 2021
Merged

Fix dataclass comment typo (_eq__ -> __eq__)#26433
ericvsmith merged 1 commit into
python:mainfrom
SeanGrady:fix-dataclass-comment-typo

Conversation

@SeanGrady

@SeanGrady SeanGrady commented May 28, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

What it says on the tin. Small thing, but figured I'd submit this just in case.

@SeanGrady SeanGrady requested a review from ericvsmith as a code owner May 28, 2021 19:37
@the-knights-who-say-ni

the-knights-who-say-ni commented May 28, 2021

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@SeanGrady

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@ericvsmith

ericvsmith commented May 28, 2021

Copy link
Copy Markdown
Member

@SeanGrady : Since this is a one character change, I'm going to commit it without the CLA. But if you submit a more substantial PR, you will need to sign it.

@ericvsmith ericvsmith merged commit 7e6f237 into python:main May 28, 2021
@miss-islington

miss-islington commented May 28, 2021

Copy link
Copy Markdown
Contributor

Thanks @SeanGrady for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented May 28, 2021

Copy link
Copy Markdown

GH-26436 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 28, 2021
@SeanGrady @miss-islington
Fix dataclass comment typo _eq__ -> __eq__ (pythonGH-26433)
946f98b 
(cherry picked from commit 7e6f237)

Co-authored-by: Sean Grady <vedicmonk@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 28, 2021
@SeanGrady @miss-islington
Fix dataclass comment typo _eq__ -> __eq__ (pythonGH-26433)
bdfdc95 
(cherry picked from commit 7e6f237)

Co-authored-by: Sean Grady <vedicmonk@gmail.com>
@bedevere-bot

bedevere-bot commented May 28, 2021

Copy link
Copy Markdown

GH-26437 is a backport of this pull request to the 3.9 branch.

ericvsmith pushed a commit that referenced this pull request May 29, 2021
@miss-islington @SeanGrady
Fix dataclass comment typo _eq__ -> __eq__ (GH-26433) (GH-26436)
1757ddd 
(cherry picked from commit 7e6f237)

Co-authored-by: Sean Grady <vedicmonk@gmail.com>

Co-authored-by: Sean Grady <vedicmonk@gmail.com>
ericvsmith pushed a commit that referenced this pull request May 29, 2021
@miss-islington @SeanGrady
Fix dataclass comment typo _eq__ -> __eq__ (GH-26433) (GH-26437)
d5b657b 
(cherry picked from commit 7e6f237)

Co-authored-by: Sean Grady <vedicmonk@gmail.com>

Co-authored-by: Sean Grady <vedicmonk@gmail.com>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericvsmith ericvsmith Awaiting requested review from ericvsmith ericvsmith is a code owner

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@SeanGrady @the-knights-who-say-ni @ericvsmith @miss-islington @bedevere-bot @nanjekyejoannah